Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated 'crashed' event #685

Merged
merged 3 commits into from
Jan 8, 2021

Conversation

knownasilya
Copy link
Contributor

@knownasilya knownasilya commented Jan 8, 2021

@RobbieTheWagner
Copy link
Member

@knownasilya do you happen to know what version of Electron it was deprecated in? We may want to take a stance on what Electron versions we support too.

@knownasilya
Copy link
Contributor Author

knownasilya commented Jan 8, 2021

Well the new event was added here (8.4) https://www.electronjs.org/releases/stable?version=8&page=2#release-notes-for-v840

@knownasilya
Copy link
Contributor Author

Also looks like deprecated in 8 electron/electron#23096

@bendemboski
Copy link
Member

I'm not sure we need to take a version stance because of this. This code is in the blueprint, and the blueprint will always install the latest version of Electron. We've never said that the blueprint-generated code is compatible with past versions of Electron (that would incur a pretty big maintenance cost), so if users go in and customize their Electron version, it's completely reasonable for them to expect to have to update the blueprint-generated code to work with the older version as well.

I suppose we could mention this in the documentation somewhere, but I'm not even sure that's necessary...seems like an edge case that someone would install ember-electron without the intent to use the latest version of Electron.

@knownasilya
Copy link
Contributor Author

@bendemboski updated

@knownasilya knownasilya merged commit d5a649e into master Jan 8, 2021
@knownasilya knownasilya deleted the fix/replace-deprecated-crashed-event branch January 8, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants